This repository was archived by the owner on May 26, 2023. It is now read-only.
Log whether auth is enabled #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
changed the title
feedmeapples
force-pushed
the
log-augh
branch
from
d62d4a4 to
7f0be4a
Compare
stevekinney
approved these changes
Oct 21, 2021
| @@ -64,6 +65,10 @@ const getTlsConfig = () => { | |||
| }; | |||
| }; | |||
|
|
|||
| logger.log( | |||
| `Auth is ${readConfigSync().auth?.enabled ? 'enabled' : 'disabled'} in config` | |||
There was a problem hiding this comment.
Do we want to check to see if the return value of readConfigSync() is undefined or is it not necessary because know it will always return a value?
readConfigSync()?.auth?.enabledThere was a problem hiding this comment.
the server won't start up if the config file is not present. There is a default config file always present and users can replace it (mount a new one through docker) if they want to
feedmeapples
added a commit
that referenced
this pull request
Mar 1, 2022
* Bump tar from 4.4.13 to 4.4.15 (#368) Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.15. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.13...v4.4.15) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump path-parse from 1.0.6 to 1.0.7 (#370) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Support refreshing TLS certs in background (#369) * Fix gRPC connection failure in insecure connection (#374) * Show workflow state transitions (#375) * Bump tar from 4.4.15 to 4.4.19 (#382) Bumps [tar](https://github.com/npm/node-tar) from 4.4.15 to 4.4.19. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.15...v4.4.19) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for built-in HTTPS (#379) * adding support for running temporal web using HTTPS based on ENV vars * Link to new executions for more event types (#380) * Rename left over task list -> queue (#389) * Add maintenance mode notification in readme (#390) * Add maintenance mode notification in readme * Update README.md * Update README.md * Update README.md Co-authored-by: swyx <[email protected]> * Fix history exported JSON formatting (#392) * Make header namespace link always clickable (#393) * Bump tmpl from 1.0.4 to 1.0.5 (#395) Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump prismjs from 1.24.0 to 1.25.0 (#394) Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.0 to 1.25.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.24.0...v1.25.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update proto api (#396) * Tag Web v1.12.0 (#397) * Added LoginRadius OAuth Doc Reference (#402) Added LoginRadius OAuth Doc Reference to the list * Log whether auth is enabled (#401) * Extend Temporal API error messages (#400) * Tag Web v1.13.0 (#407) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: arnesenfamily <[email protected]> Co-authored-by: David Reiss <[email protected]> Co-authored-by: swyx <[email protected]> Co-authored-by: IArchna <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Logs auth enabled state on app load
Why?
help debugging whether the config file is read (community ask)
Checklist
Closes
How was this tested: