Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to reading auth user from cookie #863

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Oct 3, 2022

What was changed

Started reading auth user data from cookie instead of html

Why?

making ui-server API only server

Checklist

  1. Closes

  2. How was this tested:

verified with temporalio/ui-server#219

  • logging in
  • attaching access token in API requests
  • attaching access token in Data Converter requests
  1. Any docs updates needed?

@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
holocene ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 11:37PM (UTC)
ui ✅ Ready (Inspect) Visit Preview Oct 3, 2022 at 11:37PM (UTC)

@cypress
Copy link

cypress bot commented Oct 3, 2022



Test summary

68 0 0 0


Run details

Project Temporal UI
Status Passed
Commit 1cc32368c4 ℹ️
Started Oct 3, 2022 11:37 PM
Ended Oct 3, 2022 11:41 PM
Duration 03:09 💡
OS Linux Ubuntu - 20.04
Browser Chrome 105

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@feedmeapples feedmeapples merged commit 8e910a1 into main Oct 4, 2022
@feedmeapples feedmeapples deleted the read-auth-user-from-cookie branch October 4, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants