-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ui-server to use the new protos #1775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
reviewed
Jan 4, 2024
The actual error we hit was ``` 2024/01/04 13:08:28 Failed to marshal *status.Status: temporalproto: google.protobuf.Any: unable to resolve "type.googleapis.com/temporal.api.errordetails.v1.NotFoundFailure": proto: not found` ```
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
January 22, 2024 21:21
laurakwhit
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ests to cover object/array inputs, and show empty string for ParentNamespaceID in workflow cell.
Alex-Tideman
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This updates the UI server to use our new google/protobuf-compiled proto code. This introduces a breaking change to our JSON formatting: all proto enums are now in SCREAMING_SNAKE_CASE rather than camelCase.
This PR (and branch) is just to get y'all what you need to update the UI itself and this should not be merged on its own.
Screenshots (if applicable) 📸
N/A
Design Considerations 🎨
N/A
Testing 🧪
How was this tested 👻
No tests were added and all tests have likely broken. This PR is a starting point upon which the UI itself can be updated. I've done some very basic manual testing to ensure the API returns what we expect it to, like the new SCREAMING_SNAKE_ENUMS:
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?