Add configuration to forward HTTP headers #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedmeapples
force-pushed
the
add-headers-forwarding
branch
from
5e38a99 to
16435d7
Compare
Alex-Tideman
reviewed
Aug 2, 2022
| @@ -43,4 +44,9 @@ session: | |||
| filesystem: | |||
| # if non-empty, switches to filesystem store instead of cookie store. Increases size limit from 4K to 64K | |||
| path: {{ default .Env.TEMPORAL_SESSION_STORE_PATH "" }} | |||
| disableWriteActions: {{ default .Env.TEMPORAL_DISABLE_WRITE_ACTIONS "false" }} | |||
| forwardHeaders: | |||
| {{ if .Env.TEMPORAL_FORWARD_HEADERS }} | |||
There was a problem hiding this comment.
What exactly is the expected env var here? An array of strings?
There was a problem hiding this comment.
added a comment
Alex-Tideman
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Allows to specify headers that will be passed from HTTP requests to gRPC Temporal backend
Why?
Additional headers can be used for security and other use cases
Checklist
Closes
How was this tested:
tested passing
TEMPORAL_FORWARD_HEADERS=X-Forwarded-For,X-Forwarded-Portin docker image