Define our own workflow service for the UI. #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't replicate all of the protobuf and types, this makes it impossible to embed the UI server alongside any code referring to Temporal server as they both try and register the protobuf types causing Go to panic.
stevekinney
approved these changes
Jul 20, 2022
feedmeapples
approved these changes
Jul 20, 2022
|
Hmm, testing locally. This isn't quite ready yet. |
Otherwise the handler expects to find the temporal.ui.WorkflowService on Temporal's side.
|
Fixed. Re-using the name for the service and building only the service works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a new WorkflowService definition, with a different package name to the Temporal API workflow service. Stop build the duplicated types from the main api repo and simply refer to them as required from the new service.
Why?
To avoid re-registering all the protobuf and Go types and having a different definition for the WorkflowService to that in the upstream API.
Checklist
Closes #80
How was this tested:
Adjusted temporalite repo to use this fork of the ui-server code and confirmed that
go run ...works without panicing.Any docs updates needed?
Nope.