Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplication of auth headers #174

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Avoid duplication of auth headers #174

merged 1 commit into from
Jul 5, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Jul 5, 2022

What was changed

ensuring only a single auth header is set

Why?

grpc-gateway may forward authorization header. This could result in a duplication of auth header because the auth was also appended from a cookie/authorization header in the custom logic

Checklist

  1. Closes

  2. How was this tested:

google oauth

cloud automated testing tbd

  1. Any docs updates needed?

@feedmeapples feedmeapples requested a review from Alex-Tideman July 5, 2022 19:31
@feedmeapples feedmeapples merged commit 1951f34 into main Jul 5, 2022
@feedmeapples feedmeapples deleted the avoid-auth-dups branch July 5, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants