Implement ConfigProvider interface on *Config type #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlegrone
force-pushed
the
jlegrone/config-config-provider
branch
from
832c032 to
d7aaf54
Compare
jlegrone
commented
Feb 25, 2022
Comment on lines
+99
to
+101
| func (c *Config) GetConfig() (*Config, error) { | ||
| return c, nil | ||
| } |
There was a problem hiding this comment.
We could also call the Validate method here and bubble up any error, but I figure that makes more sense for the server to do at startup rather than push the responsibility into every ConfigProvider implementation.
feedmeapples
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
The
Configstruct now implements theConfigProviderinterface.Why?
This is convenient for users who just want to supply hardcoded config, eg. Temporalite.
Checklist
Closes
How was this tested: