This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
check if the db file path dir exists before setting up schema #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jlegrone
reviewed
Aug 1, 2022
jlegrone
approved these changes
Aug 2, 2022
|
LGTM, please just sign the CLA and we should be good to go. Thanks! |
|
I agreed to the CLA a couple times but I'm not sure why it's not showing |
|
Might be because your commits are signed off as @zillow-jeff, not @theverything. |
cretz
approved these changes
Aug 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR checks if the parent directories exist for the given database file path and returns a more descriptive error to the user.
Why?
The current error output is confusing. Closes #55.
How did you test it?
Yes. Tested it locally.
Potential risks
Users are confused by a new error?
Is hotfix candidate?
No.