This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added methods to create new test worker with options and custom clients #81
Added methods to create new test worker with options and custom clients #81
Changes from 12 commits
eb275a1
c68d48f
be0f441
181e25a
1e6cc2a
59193f0
57ba03f
5ca8926
e5e663b
76506da
8fda9bb
8405c53
0af96af
6b597c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm just thinking out loud, we should probably deprecate this and rename to
NewWorker
before the first release. That would be more consistent withNewClientWithOptions
andNewWorkerWithOptions
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can work on a followup PR that changes this. Should it be a breaking change, or should it support both methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just mark as deprecated for now (no breaking change), and then remove it before the first tagged release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: calling this function probably shouldn't have a side effect of modifying
TestServer
fields. Instead we should set any defaults necessary during initialization.