This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
fix: log level support #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be super great to get this in! |
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 42.02% 40.38% -1.64%
==========================================
Files 12 12
Lines 740 770 +30
==========================================
Hits 311 311
- Misses 407 437 +30
Partials 22 22
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
jlegrone
approved these changes
May 5, 2022
| switch c.String(logLevelFlag) { | ||
| case "debug", "info", "warn", "error", "fatal": | ||
| default: | ||
| return cli.Exit(fmt.Sprintf("bad value %q passed for flag %q", c.String(logLevelFlag), logLevelFlag), 1) |
There was a problem hiding this comment.
Thanks for the validation here!
Small nit -- it would be great if the error message included the set of allowed values, with the same source of truth used to generate the log-level flag's usage string. However this isn't high priority since the allowed values should be pretty static, so I'll leave it open to further contribution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding an optional flag to set log level.
Why?
Closes #57
How did you test it?
go run ./cmd/temporalite/ start --ephemeral --log-level=info
go run ./cmd/temporalite/ start --ephemeral --log-level=debug
go run ./cmd/temporalite/ start --ephemeral --log-level=info --log-format=pretty
go run ./cmd/temporalite/ start --ephemeral --log-level=debug --log-format=pretty
go run ./cmd/temporalite/ start --ephemeral
Potential risks
log level default (if omitted) is changed to info from debug
Is hotfix candidate?
no