This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Automatically stop server after test completion via T.Cleanup #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlegrone
force-pushed
the
jlegrone/test-cleanup
branch
from
f785c95 to
5dab96f
Compare
lminaudier
approved these changes
Dec 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Test servers now are automatically shut down after the parent test case completes via T.Cleanup.
Why?
This reduces the boilerplate needed to set up and tear down test servers.
How did you test it?
Verified by logging in the cleanup function and running tests.
Potential risks
Folks might not want to tie test server lifecycle to a single Go test. In this case table tests or not passing the
WithToption may be a better fit.