This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
changes tally to use v4.1.0 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch includes the fix we're wanting to include.
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 45.06% 45.06%
=======================================
Files 11 11
Lines 648 648
=======================================
Hits 292 292
Misses 337 337
Partials 19 19 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the dependency on Tally to use v4.1.0, this is to solve issue #18. I did run the tests as the workflow explains to ensure it still compiles and passes the tests.
Potential risks
I do not see any potential risks on this PR besides being able to import the temporalite go library (which is where we are now according to the issue).
Is hotfix candidate?
I would say it is a candidate for hotfix, not sure that this impacts other communities.