This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
fix: Ensures directory path to db file exists #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jlegrone
reviewed
Sep 23, 2022
cretz
reviewed
Sep 23, 2022
hferentschik
force-pushed
the
issue-122
branch
2 times, most recently
from
945a7ac to
c6fb90f
Compare
jlegrone
reviewed
Sep 23, 2022
hferentschik
force-pushed
the
issue-122
branch
from
c6fb90f to
f426c5c
Compare
cretz
suggested changes
Sep 23, 2022
hferentschik
force-pushed
the
issue-122
branch
from
f426c5c to
d7bf9cb
Compare
jlegrone
approved these changes
Sep 24, 2022
cretz
approved these changes
Sep 24, 2022
| @@ -162,6 +163,13 @@ func buildCLI() *cli.App { | |||
| return cli.Exit(fmt.Sprintf("ERROR: only one of %q or %q flags may be passed at a time", ephemeralFlag, dbPathFlag), 1) | |||
| } | |||
|
|
|||
| // Make sure the default db path exists (user does not specify path explicitly) | |||
| if !c.IsSet(dbPathFlag) { | |||
There was a problem hiding this comment.
Can you confirm this is not considered "set" when left as default?
There was a problem hiding this comment.
Yes this leads to the correct behavior. I'd like to add an integration test though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #122