Change CLI approach and copyright fix

cmd/temporalite/main.go

@@ -37,20 +37,19 @@ var (
 )
 
 const (
-	ephemeralFlag            = "ephemeral"
-	dbPathFlag               = "filename"
-	portFlag                 = "port"
-	metricsPortFlag          = "metrics-port"
-	uiPortFlag               = "ui-port"
-	headlessFlag             = "headless"
-	ipFlag                   = "ip"
-	logFormatFlag            = "log-format"
-	logLevelFlag             = "log-level"
-	namespaceFlag            = "namespace"
-	pragmaFlag               = "sqlite-pragma"
-	configFlag               = "config"
-	dynamicConfigValueFlag   = "dynamic-config-value"
-	searchAttributeCacheFlag = "search-attribute-cache"
+	ephemeralFlag          = "ephemeral"
+	dbPathFlag             = "filename"
+	portFlag               = "port"
+	metricsPortFlag        = "metrics-port"
+	uiPortFlag             = "ui-port"
+	headlessFlag           = "headless"
+	ipFlag                 = "ip"
+	logFormatFlag          = "log-format"
+	logLevelFlag           = "log-level"
+	namespaceFlag          = "namespace"
+	pragmaFlag             = "sqlite-pragma"
+	configFlag             = "config"
+	dynamicConfigValueFlag = "dynamic-config-value"
 )
 
 func init() {
@@ -154,10 +153,6 @@ func buildCLI() *cli.App {
 					Name:  dynamicConfigValueFlag,
 					Usage: `dynamic config value, as KEY=JSON_VALUE (meaning strings need quotes)`,
 				},
-				&cli.BoolFlag{
-					Name:  searchAttributeCacheFlag,
-					Usage: `enable search attribute cache`,
-				},
 			},
 			Before: func(c *cli.Context) error {
 				if c.Args().Len() > 0 {
@@ -278,16 +273,17 @@ func buildCLI() *cli.App {
 				if err != nil {
 					return err
 				}
+				// If there is no config value for search attribute cache disabling,
+				// default it to true
+				if len(configVals[dynamicconfig.ForceSearchAttributesCacheRefreshOnRead]) == 0 {
+					configVals[dynamicconfig.ForceSearchAttributesCacheRefreshOnRead] = []dynamicconfig.ConstrainedValue{
+						{Value: true},
+					}
+				}
 				for k, v := range configVals {
 					opts = append(opts, temporalite.WithDynamicConfigValue(k, v))
 				}
 
-				// We put the search attribute cache flag after dynamic config since it
-				// is essentially just a dynamic config setting internally
-				if !c.Bool(searchAttributeCacheFlag) {
-					opts = append(opts, temporalite.WithSearchAttributeCacheDisabled())
-				}
-
 				s, err := temporalite.NewServer(opts...)
 				if err != nil {
 					return err

cmd/temporalite/main_test.go

@@ -1,3 +1,7 @@
+// Unless explicitly stated otherwise all files in this repository are licensed under the MIT License.
+//
+// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2021 Datadog, Inc.
+
 package main
 
 import (