-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go SDK to v1.26.0-rc.2 #5396
Conversation
4f90355
to
1380e7d
Compare
1380e7d
to
19cf728
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we hold off on this until we merge the nexus feature branch?
All of the fixes you made are addressed there and will generate conflicts.
Doesn't matter to me. I was under the impression we wanted to cherry pick these changes to the latest release candidate, merging on top of the nexus feature branch would make that hard. |
This is now unfortunately blocking my work on our OpenAPI specs; do you have a timeline for this? The OpenAPI work isn't urgent |
I have another PR to update the otelgrpc go package to 0.46.0. I didn't realize that this PR covers that change. Do you have an estimate on when this will be available? Thanks. |
It was decided we won't pick up |
Reopened since we plan on delaying the nexus feature branch merge. |
This was fixed by temporalio/temporal#5396 but because there are incompatible changes between api-go, our sdk, and the temporal server itself we haven't pulled this change into the server. Those should be resolved soon but in the meantime we're going to pin the version of the API used.
@@ -140,6 +140,11 @@ var ( | |||
"ListBatchOperations": 1, | |||
"StartBatchOperation": 1, | |||
"StopBatchOperation": 1, | |||
|
|||
// TODO: added temporarily here; need to be check when implemented if it's the right place and priority |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bergundy is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about this, these APIs are not implemented.
Update Go SDK to v1.26.0-rc.2 Use a tagged Go SDK for the server release --------- Co-authored-by: Roey Berman <[email protected]>
What changed?
Update Go SDK to v1.26.0-rc.2
Why?
Use a tagged Go SDK for the server release