Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go SDK to v1.26.0-rc.2 #5396

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Update Go SDK to v1.26.0-rc.2 #5396

merged 4 commits into from
Feb 21, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

What changed?

Update Go SDK to v1.26.0-rc.2

Why?

Use a tagged Go SDK for the server release

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review February 7, 2024 16:28
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner February 7, 2024 16:28
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hold off on this until we merge the nexus feature branch?
All of the fixes you made are addressed there and will generate conflicts.

@Quinn-With-Two-Ns
Copy link
Contributor Author

Can we hold off on this until we merge the nexus feature branch?

Doesn't matter to me. I was under the impression we wanted to cherry pick these changes to the latest release candidate, merging on top of the nexus feature branch would make that hard.

@tdeebswihart
Copy link
Contributor

Can we hold off on this until we merge the nexus feature branch? All of the fixes you made are addressed there and will generate conflicts.

This is now unfortunately blocking my work on our OpenAPI specs; do you have a timeline for this? The OpenAPI work isn't urgent

@vinimona
Copy link

vinimona commented Feb 16, 2024

I have another PR to update the otelgrpc go package to 0.46.0. I didn't realize that this PR covers that change. Do you have an estimate on when this will be available? Thanks.

@Quinn-With-Two-Ns
Copy link
Contributor Author

It was decided we won't pick up api 1.27.0 or the go sdk v1.26.0-rc.2 for the Server release I am going to close this PR since it isn't needed at the moment and will conflict with nexus and open up a PR to update the Server once the go SDK v1.26.0 if released and the nexus work is merged.

@bergundy
Copy link
Member

Reopened since we plan on delaying the nexus feature branch merge.

tdeebswihart added a commit to temporalio/cli that referenced this pull request Feb 21, 2024
This was fixed by temporalio/temporal#5396 but
because there are incompatible changes between api-go, our sdk, and the
temporal server itself we haven't pulled this change into the server.

Those should be resolved soon but in the meantime we're going to pin the
version of the API used.
@@ -140,6 +140,11 @@ var (
"ListBatchOperations": 1,
"StartBatchOperation": 1,
"StopBatchOperation": 1,

// TODO: added temporarily here; need to be check when implemented if it's the right place and priority
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bergundy is this correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about this, these APIs are not implemented.

@bergundy bergundy merged commit 0d6536f into main Feb 21, 2024
58 checks passed
@bergundy bergundy deleted the update-sdk-1-26-0-rc-2 branch February 21, 2024 20:54
tdeebswihart pushed a commit that referenced this pull request Mar 1, 2024
Update Go SDK to v1.26.0-rc.2

Use a tagged Go SDK for the server release

---------

Co-authored-by: Roey Berman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants