Validate workflow task start time when complete #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Jul 21, 2023
alexshtin
reviewed
Jul 21, 2023
yycptt
approved these changes
Jul 21, 2023
yiminc
force-pushed
the
validate_start_time
branch
from
f791cd6 to
742f66f
Compare
alexshtin
approved these changes
Jul 21, 2023
yycptt
pushed a commit
that referenced
this pull request
Jul 21, 2023
<!-- Describe what has changed in this PR --> **What changed?** Add start time to workflow task token and validate it on close. <!-- Tell your future self why have you made these changes --> **Why?** To reject concurrent speculative workflow task with same startedEventID. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Integration tests. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** No <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add start time to workflow task token and validate it on close.
Why?
To reject concurrent speculative workflow task with same startedEventID.
How did you test it?
Integration tests.
Potential risks
No
Is hotfix candidate?
Yes