Custom search attributes validation per store #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Jul 20, 2023
| @@ -95,6 +95,10 @@ var _ store.VisibilityStore = (*visibilityStore)(nil) | |||
| var ( | |||
| errUnexpectedJSONFieldType = errors.New("unexpected JSON field type") | |||
|
|
|||
| minTime = time.Unix(0, 0).UTC() | |||
| maxTime = time.Unix(0, math.MaxInt64).UTC() | |||
| maxStringLength = 32766 | |||
There was a problem hiding this comment.
I think search attribute already has size limit of 2KB.
There was a problem hiding this comment.
Well, still better to have this already in place just in case in the future we (or an OSS user) change it limit.
There was a problem hiding this comment.
Yes, storage specific validators should reflect all storage limitation. DC value can be changed.
| } | ||
| } | ||
| if err != nil { | ||
| if ignoreInvalidValues { |
There was a problem hiding this comment.
It seems we should check ignoreInvalidValues before validation? What is the point of doing the validation then ignore it?
There was a problem hiding this comment.
For the case the task with bad value. We want to check and ignore the value if it's invalid.
rodrigozhou
force-pushed
the
vis-per-store-validation
branch
from
9d40345 to
9cd238d
Compare
rodrigozhou
force-pushed
the
vis-per-store-validation
branch
2 times, most recently
from
002a803 to
95088c7
Compare
alexshtin
approved these changes
Jul 20, 2023
rodrigozhou
force-pushed
the
vis-per-store-validation
branch
from
95088c7 to
c3ede59
Compare
dnr
pushed a commit
that referenced
this pull request
Jul 21, 2023
dnr
pushed a commit
that referenced
this pull request
Jul 21, 2023
dnr
pushed a commit
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add custom search attributes validation to
VisibilityStoreinterface, and implements ES constraints.Why?
Each store can have different constraint that might reject the value when inserting.
Eg: In ES, dates can only be between 1970 and 2262.
How did you test it?
Potential risks
Is hotfix candidate?