Fail force-replication fast if any GenerateReplicationTasks/GenerateAndVerifyReplicationTasks activity returns error #4642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hehaifengcn
changed the title
hehaifengcn
force-pushed
the
haifengh/v1.21.2-verify-test-pr
branch
from
9827066 to
d0c4e47
Compare
yux0
approved these changes
Jul 18, 2023
hehaifengcn
force-pushed
the
haifengh/v1.21.2-verify-test-pr
branch
from
c0fd549 to
10abc6d
Compare
wxing1292
approved these changes
Jul 18, 2023
meiliang86
approved these changes
Jul 19, 2023
hehaifengcn
force-pushed
the
haifengh/v1.21.2-verify-test-pr
branch
from
c5417f9 to
b6a707d
Compare
…AndVerifyReplicationTasks activity returns error
hehaifengcn
force-pushed
the
haifengh/v1.21.2-verify-test-pr
branch
from
b6a707d to
8d5a9be
Compare
wxing1292
pushed a commit
that referenced
this pull request
Jul 21, 2023
…ndVerifyReplicationTasks activity returns error (#4642) <!-- Describe what has changed in this PR --> **What changed?** <!-- Tell your future self why have you made these changes --> **Why?** Currently, the workflow will wait for all GenerateReplicationTasks activity to complete. The change will fail the workflow fast if any GenerateReplicationTasks activity failed. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** unit test and cluster test. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
hehaifengcn
added a commit
that referenced
this pull request
Jul 21, 2023
…ndVerifyReplicationTasks activity returns error (#4642) <!-- Describe what has changed in this PR --> **What changed?** <!-- Tell your future self why have you made these changes --> **Why?** Currently, the workflow will wait for all GenerateReplicationTasks activity to complete. The change will fail the workflow fast if any GenerateReplicationTasks activity failed. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** unit test and cluster test. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
hehaifengcn
added a commit
that referenced
this pull request
Jul 22, 2023
…ndVerifyReplicationTasks activity returns error (#4642) <!-- Describe what has changed in this PR --> **What changed?** <!-- Tell your future self why have you made these changes --> **Why?** Currently, the workflow will wait for all GenerateReplicationTasks activity to complete. The change will fail the workflow fast if any GenerateReplicationTasks activity failed. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** unit test and cluster test. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Currently, the workflow will wait for all GenerateReplicationTasks activity to complete. The change will fail the workflow fast if any GenerateReplicationTasks activity failed.
How did you test it?
unit test and cluster test.
Potential risks
Is hotfix candidate?
No.