Change the type of "Task List Kind" from int32 to a protobuff enum, TaskListKind #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
changed the title
int32 to a protobuff enum, TaskListKind
alexshtin
approved these changes
Apr 30, 2020
shawnhathaway
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replacing the type of "Task List Kind" from
int32to a protobuff enum,TaskListKind:https://github.com/temporalio/temporal-proto/blob/8a95bbac3a1febf23d2e7f43954fa525ca300864/tasklist/enum.proto#L29-L32
Why?
This is part of the effort to make the code cleaner and more maintainable, via removing redundant types, and by using stronger typing.
How did you test it?
I build the code and ran unit tests.
Potential risks
There should be no externally-visible functionality change as a result of this change, this change is purely a code refactoring. If any of the existing functionality breaks, we should be able to fix or back out.