Config worker use public frontend endpoint #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not use the internal endpoint? |
It should. See: #3160 |
meiliang86
approved these changes
Jul 28, 2022
yycptt
approved these changes
Jul 29, 2022
yux0
added a commit
that referenced
this pull request
Jul 29, 2022
* Config worker use public frontend endpoint * Update integration test
I saw that, I'm just confused how these relate to each other |
hehaifengcn
reviewed
Jul 29, 2022
| @@ -89,6 +101,13 @@ func ConfigProvider( | |||
| ) | |||
| } | |||
|
|
|||
| func FrontendClientProvider( | |||
There was a problem hiding this comment.
can we rename to LocalFrontendClientProvider and also add some comment that why PublicClient is actually Local endpoint?
yux0
added a commit
to yux0/temporal
that referenced
this pull request
Aug 3, 2022
* Config worker use public frontend endpoint * Update integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Config worker use public frontend endpoint
Why?
Config worker use public frontend endpoint should use the endpoint from public client config.
How did you test it?
Potential risks
Is hotfix candidate?