Updates to metrics interface, road to deprecate metrics.Reporter #2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreiding
commented
Jun 2, 2022
yiminc
reviewed
Jun 2, 2022
yiminc
reviewed
Jun 3, 2022
yiminc
approved these changes
Jun 3, 2022
yiminc
reviewed
Jun 3, 2022
alexshtin
approved these changes
Jun 3, 2022
Sushisource
pushed a commit
to Sushisource/temporal
that referenced
this pull request
Jun 7, 2022
…poralio#2935) * Updates to metrics interface, road to deprecate metrics.Reporter * adding tag filtering support and review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Metric interface implementations adapted to new interface and implementation.
Deprecated legacy interfaces.
Why?
Make extensibility of metrics reporter simpler.
How did you test it?
Local tests.
Potential risks
Inconsistency of metric names between versions.
Still testing and validating.
Is hotfix candidate?
No.