Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History queue processor task loading host RPS limit #2920

Merged
merged 2 commits into from
Jun 1, 2022
Merged

History queue processor task loading host RPS limit #2920

merged 2 commits into from
Jun 1, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented May 31, 2022

What changed?

  • Add host RPS limit for history queue task loading

Why?

  • Mainly for Rate limit failover queue task loading #2912
  • But also generally we need a host level rps limit for task loading. Per shard rps limit will still consume all available persistence token on a host when all shards are busy.

How did you test it?

  • Tested locally

Potential risks

  • No, by default the host rps limit is disabled and we use persistence rps as fallback

Is hotfix candidate?

  • no

@yycptt yycptt requested review from meiliang86 and yiminc May 31, 2022 19:09
@yycptt yycptt requested a review from a team as a code owner May 31, 2022 19:09
yiminc
yiminc approved these changes May 31, 2022
View reviewed changes
service/history/queueProcessorFactory.go Outdated Show resolved Hide resolved
@yycptt yycptt merged commit 78beb81 into temporalio:master Jun 1, 2022
@yycptt yycptt deleted the host-queue-rps-limit branch June 1, 2022 04:46
Sushisource pushed a commit to Sushisource/temporal that referenced this pull request Jun 7, 2022
@yycptt @Sushisource
History queue processor task loading host RPS limit (temporalio#2920)
b55b56e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@wxing1292 wxing1292 wxing1292 approved these changes

@meiliang86 meiliang86 Awaiting requested review from meiliang86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @wxing1292 @yiminc