Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cgo by default #2874

Merged
merged 2 commits into from
May 20, 2022
Merged

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented May 20, 2022

What changed?
Disable cgo by default.

Why?

When make runs a recipe, variables defined in the makefile are placed into the environment of each shell. This allows you to pass values to sub-make invocations (see Recursive Use of make). By default, only variables that came from the environment or the command line are passed to recursive invocations. You can use the export directive to pass other variables. See Communicating Variables to a Sub-make, for full details.

image

How did you test it?
Run manually.

Potential risks
No risks.

Is hotfix candidate?
No.

@alexshtin alexshtin requested a review from a team as a code owner May 20, 2022 00:03
@alexshtin alexshtin enabled auto-merge (squash) May 20, 2022 05:21
@alexshtin alexshtin merged commit 1eed3a7 into temporalio:master May 20, 2022
@alexshtin alexshtin deleted the fix/disable-cgo branch May 20, 2022 05:37
Sushisource pushed a commit to Sushisource/temporal that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants