Development environment for multi cluster setup #2848
Conversation
| @@ -85,6 +89,8 @@ archival: | |||
| filestore: | |||
| fileMode: "0666" | |||
| dirMode: "0766" | |||
| gstorage: | |||
There was a problem hiding this comment.
You know better. I found it in one the configs and just copied it everywhere. Should it be in development_cass-archival.yaml only?
There was a problem hiding this comment.
My understanding is the dev config for file store and it will ignore the gstorage config. @yycptt Do you have context here?
There was a problem hiding this comment.
I think we should keep it. Although the default URI is local file store, the gstorage section may still be used if someone register a namespace with gcp archival URI in local environment for development purpose.
| @@ -85,6 +89,8 @@ archival: | |||
| filestore: | |||
| fileMode: "0666" | |||
| dirMode: "0766" | |||
| gstorage: | |||
There was a problem hiding this comment.
I think we should keep it. Although the default URI is local file store, the gstorage section may still be used if someone register a namespace with gcp archival URI in local environment for development purpose.
| URI: "file:///tmp/temporal_vis_archival/development" | ||
|
|
||
| publicClient: | ||
| hostPort: "localhost:7233" | ||
|
|
||
| dynamicConfigClient: | ||
| filepath: "config/dynamicconfig/development_es.yaml" | ||
| pollInterval: "10s" | ||
|
|
There was a problem hiding this comment.
Previously when I do --zone es start, this file will be merged with development.yaml and result in using dual visibility manager, which is super confusing...
I like the new approach, just not sure if this will be surprising for others who is currently using dual manager setup.
|
|
||
| dynamicConfigClient: | ||
| filepath: "config/dynamicconfig/development_es.yaml" | ||
| pollInterval: "10s" |
There was a problem hiding this comment.
It is not there in any of configs. Why do you want it?
There was a problem hiding this comment.
It actually does present in few configs. I am removing it from everywhere.
What changed?
Add development environment for multi cluster setup:
make start-dependencies-cdc/make stop-dependencies-cdcto run dedicated UIs forstandby(port8081) andother(port8082) clusters.make install-schema-cdcto install all schemas, including Elasticsearch for advnaced visibility.make start-cdc-active,make start-cdc-standby, andmake start-cdc-otherto run corresponding cluster with advanced visibility enabled.Also:
development.yamltodevelopment_cass.yamlto prevent config inheritance. Previouslydevelopment.yamlwas always loaded.Why?
To improve local cross DC devlopment expirience.
How did you test it?
Run locally.
Potential risks
No risks.
Is hotfix candidate?
No.