Expose namespace data #2804
Merged
Expose namespace data #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
May 5, 2022
common/namespace/namespace.go
Outdated
Comment on lines
227
to
233
| func (ns *Namespace) GetCustomData() map[string]string { | ||
| res := make(map[string]string, len(ns.info.Data)) | ||
| for k, v := range ns.info.Data { | ||
| res[k] = v | ||
| } | ||
| return res | ||
| } |
There was a problem hiding this comment.
does it make sense to pass in a key so you only return the value and no need to make a copy of the map.
meiliang86
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Expose namespace data
Why?
Expose namespace data so we can use the customized data.
How did you test it?
Unit test
Potential risks
Is hotfix candidate?