Move history API logic into its own package #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move workflow creation logic util into api package * Simplify history engine impl
yycptt
approved these changes
Apr 28, 2022
yycptt
reviewed
Apr 28, 2022
| return newWorkflowContext, newMutableState, nil | ||
| } | ||
|
|
||
| func CreateMutableState( |
There was a problem hiding this comment.
probably workflow/util.go as it's not only used by api logic?
There was a problem hiding this comment.
this is actually only used by API:
- start
- signal with start
- command causing workflow to retry
let me know you comment, will address in later PRs
There was a problem hiding this comment.
I think I saw it used in task executor. I don't actually have a very strong opinion on where it should be placed.
This was referenced Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Code simplification & restructure
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
No