-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add statsd tag separator capability #2763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jbreiding Can you review this soon? It's blocking our upgrade path currently. |
jbreiding
reviewed
Jun 6, 2022
jbreiding
reviewed
Jun 6, 2022
apologies for the delay in review, thank you for the contribution. I have a couple of comments. |
jbreiding
approved these changes
Jun 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add additional tagging support via configuration to the statsd reporter. Currently, stats are emitted with tags embedded directly in the name. For example, if the stat is
hello.world
and the tags are{universe: milkyWay, planet: earth}
the stat will be emitted as:This remains the default behavior.
With this PR, if a tag separator is specified in the config the stat will be emitted with tags using that separator. For example, if the stat is
hello.world
and the tags are{universe: milkyWay, planet: earth}
and the separator is,
, the stat will be emitted asWhy?
Some statsd ingestion pipelines (e.g. Datadog and InfluxDB) support this form of stats tagging.
How did you test it?
Unit tests.
Potential risks
Is hotfix candidate?
No