Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statsd tag separator capability #2763

Merged
merged 9 commits into from
Jun 12, 2022
Merged

Conversation

danielhochman
Copy link
Contributor

What changed?
Add additional tagging support via configuration to the statsd reporter. Currently, stats are emitted with tags embedded directly in the name. For example, if the stat is hello.world and the tags are {universe: milkyWay, planet: earth} the stat will be emitted as:

hello.world.planet.earth.universe.milkyWay

This remains the default behavior.

With this PR, if a tag separator is specified in the config the stat will be emitted with tags using that separator. For example, if the stat is hello.world and the tags are {universe: milkyWay, planet: earth} and the separator is ,, the stat will be emitted as

hello.world,universe=milkyWay,planet=earth

Why?
Some statsd ingestion pipelines (e.g. Datadog and InfluxDB) support this form of stats tagging.

How did you test it?
Unit tests.

Potential risks

  • Stats will not emit properly leading to a lack of visibility.

Is hotfix candidate?
No

@danielhochman danielhochman requested a review from a team as a code owner April 25, 2022 17:08
@yiminc yiminc requested a review from jbreiding April 30, 2022 00:06
@danielhochman
Copy link
Contributor Author

@jbreiding Can you review this soon? It's blocking our upgrade path currently.

@jbreiding
Copy link
Contributor

@jbreiding Can you review this soon? It's blocking our upgrade path currently.

apologies for the delay in review, thank you for the contribution.

I have a couple of comments.

Copy link
Contributor

@jbreiding jbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@jbreiding jbreiding merged commit 3c5b09f into temporalio:master Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants