Remove custom build info script #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/remove-custom-build-info
branch
from
cc0cec6 to
ccf743d
Compare
yiminc
approved these changes
Mar 22, 2022
Comment on lines
+70
to
+76
| case "vcs.revision": | ||
| InfoData.GitRevision = setting.Value | ||
| case "vcs.time": | ||
| if gitTime, err := time.Parse(time.RFC3339, setting.Value); err == nil { | ||
| InfoData.GitTime = gitTime | ||
| } | ||
| case "vcs.modified": |
There was a problem hiding this comment.
how do you find those keys? any documentation about what are the available keys?
There was a problem hiding this comment.
No, I wasn't able to find the doc. Release notes just describes it in general and I had to dump entire settings struct to see what is there.
There was a problem hiding this comment.
Also go version -m temporal-server shows it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove custom build info script.
Why?
Go 1.18 has built in support for emeded build info.
How did you test it?
Run localy.
Potential risks
Build time is now git time (not real build time but time of the current commit).
Is hotfix candidate?
No.