Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. improvements for error checking #2602

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Misc. improvements for error checking #2602

merged 1 commit into from
Mar 14, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 11, 2022

What changed?

  • Check task queue length in RespondWorkflowTaskCompletedRequest before sending the request to history
  • Check if child workflow info exists in ReplicateChildWorkflowExecutionStartedEvent to avoid NPE issue.

Why?

  • misc improvements.

How did you test it?

  • Existing tests

Potential risks
N/A

Is hotfix candidate?
No.

@yycptt yycptt requested a review from yiminc March 11, 2022 18:35
@yycptt yycptt requested a review from a team as a code owner March 11, 2022 18:35
@yycptt yycptt merged commit 3a3057e into temporalio:master Mar 14, 2022
@yycptt yycptt deleted the improve-error-checking branch March 14, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yiminc