Update error code and message for missing activity task. #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Mar 1, 2022
service/history/historyEngine.go
Outdated
| @@ -2850,11 +2850,11 @@ func getScheduleID( | |||
| ) (int64, error) { | |||
|
|
|||
| if activityID == "" { | |||
| return 0, serviceerror.NewInvalidArgument("Neither ActivityID nor ScheduleID is provided") | |||
| return 0, serviceerror.NewInvalidArgument("invalid ActivityID provided") | |||
There was a problem hiding this comment.
Okay, that is a fair point.
idiomatic go says errors should be lower cased so they can be fmt'ed into a logging line which may be sentenced cased.
I did depart from what was there before, happy to change though to keep consistency.
I can definitely break apart ActivityID.
Thoughts?
There was a problem hiding this comment.
I would just say activityID cannot be empty
wxing1292
approved these changes
Mar 1, 2022
yiminc
approved these changes
Mar 2, 2022
service/history/historyEngine.go
Outdated
| } | ||
| activityInfo, ok := mutableState.GetActivityByActivityID(activityID) | ||
| if !ok { | ||
| return 0, serviceerror.NewInvalidArgument("Cannot locate Activity ScheduleID") | ||
| return 0, serviceerror.NewNotFound(fmt.Sprintf("cannot locate active task for ActivityID %s, check workflow execution history for more details", activityID)) |
There was a problem hiding this comment.
suggest: cannot find pending activity with ActivityID %s
service/history/historyEngine.go
Outdated
| @@ -2850,11 +2850,11 @@ func getScheduleID( | |||
| ) (int64, error) { | |||
|
|
|||
| if activityID == "" { | |||
| return 0, serviceerror.NewInvalidArgument("Neither ActivityID nor ScheduleID is provided") | |||
| return 0, serviceerror.NewInvalidArgument("invalid ActivityID provided") | |||
There was a problem hiding this comment.
I would just say activityID cannot be empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Error code and message for missing activity task
Why?
A bit more clear on reason for failure and direction for investigation
#2538
How did you test it?
unit tests
Potential risks
None
Is hotfix candidate?
No