Treat enablement of TLS separately for server and client config #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replaced
GroupTLS.IsEnabled()withGroupTLS.IsServerEnabled()andGroupTLS.IsClientEnabled().Why?
Fixes #2448
Client may need to be enabled even when server TLS is disabled. The typical example is when client talks to a TLS-enabled load balancer.
How did you test it?
Added a unit test that reproduced #2448.
Potential risks
In theory, this changes treatment of TLS configuration and may cause some unexpected change in behavior.
In reality, this restores the behavior that existed prior to the introduction of
ClientTLS.ForceTLSflag.Is hotfix candidate?
Potentially