-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic config change diff logging #2494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ardagan
force-pushed
the
DynamicConfigLogging
branch
from
February 11, 2022 19:43
4851ea6
to
11b62f6
Compare
yiminc
reviewed
Feb 11, 2022
yycptt
reviewed
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I probably lack some context here. Have we considered changing the logging behavior at the dynamic config collection level instead of the client? At client level, we will need the logging logic for each client implementation.
yiminc
reviewed
Feb 23, 2022
Ardagan
force-pushed
the
DynamicConfigLogging
branch
from
February 23, 2022 19:45
11b62f6
to
b52f823
Compare
yiminc
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Changed diff detection on dynamic config.
Why?
Fix incorrect behavior.
How did you test it?
local/unit testing
Potential risks
Dynamic config is not updated correctly.
Is hotfix candidate?
no