Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tctl code #2461

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Remove tctl code #2461

merged 1 commit into from
Mar 22, 2022

Conversation

feedmeapples
Copy link
Contributor

What changed?

Removed tctl code base

Why?

tctl moved into its own repo https://github.com/temporalio/tctl

How did you test it?

make bins

Potential risks

CICD pipelines failure. Currently WIP to switch to the new builds based on https://github.com/temporalio/docker-builds

Is hotfix candidate?

@feedmeapples feedmeapples requested a review from a team as a code owner February 4, 2022 02:43
@feedmeapples feedmeapples marked this pull request as draft February 4, 2022 02:43
@alexshtin
Copy link
Member

You forgot to remove entry point in cmd/tools/cli/main.go.

@alexshtin
Copy link
Member

And in .goreleaser.yaml.

@feedmeapples feedmeapples marked this pull request as ready for review March 21, 2022 20:52
@feedmeapples feedmeapples force-pushed the remove-tctl branch 6 times, most recently from 3ca8e1d to a73d57d Compare March 22, 2022 01:08
@feedmeapples feedmeapples merged commit 5f77615 into master Mar 22, 2022
@feedmeapples feedmeapples deleted the remove-tctl branch March 22, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants