Wire up cluster metadata in start fx DI (#2398)

* Wire up cluster metadata in start fx DI

common/cluster/fx.go

@@ -0,0 +1,54 @@
+// The MIT License
+//
+// Copyright (c) 2020 Temporal Technologies Inc.  All rights reserved.
+//
+// Copyright (c) 2020 Uber Technologies, Inc.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+
+package cluster
+
+import (
+	"context"
+
+	"go.uber.org/fx"
+)
+
+var MetadataLifetimeHooksModule = fx.Options(
+	fx.Provide(NewMetadataFromConfig),
+	fx.Invoke(MetadataLifetimeHooks),
+)
+
+func MetadataLifetimeHooks(
+	lc fx.Lifecycle,
+	clusterMetadata Metadata,
+) {
+	lc.Append(
+		fx.Hook{
+			OnStart: func(context.Context) error {
+				clusterMetadata.Start()
+				return nil
+			},
+			OnStop: func(context.Context) error {
+				clusterMetadata.Stop()
+				return nil
+			},
+		},
+	)
+}

common/resource/fx.go

@@ -73,6 +73,9 @@ type (
 	MatchingClient    matchingservice.MatchingServiceClient
 )
 
+// Module
+// Use fx.Hook and OnStart/OnStop to manage Daemon resource lifecycle
+// See LifetimeHooksModule for detail
 var Module = fx.Options(
 	persistenceClient.Module,
 	fx.Provide(SnTaggedLoggerProvider),
@@ -82,7 +85,7 @@ var Module = fx.Options(
 	fx.Provide(HostNameProvider),
 	fx.Provide(ServiceNameProvider),
 	fx.Provide(TimeSourceProvider),
-	fx.Provide(cluster.NewMetadataFromConfig),
+	cluster.MetadataLifetimeHooksModule,
 	fx.Provide(MetricsClientProvider),
 	fx.Provide(SearchAttributeProviderProvider),
 	fx.Provide(SearchAttributeManagerProvider),