Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make SearchAttributesValue an array #692

Merged
merged 1 commit into from
Jun 10, 2022
Merged

refactor: Make SearchAttributesValue an array #692

merged 1 commit into from
Jun 10, 2022

Conversation

lorensr
Copy link
Contributor

@lorensr lorensr commented Jun 10, 2022

To prevent mixed-type array at type level. Keeping runtime check for JS users.

Background: temporalio/sdk-python#43 (comment)

Not labeling as breaking, since it can be included in the same release as SA feature.

@bergundy bergundy merged commit 4c71cf8 into main Jun 10, 2022
@bergundy bergundy deleted the sa-type branch June 10, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants