Dependency updates, Core proto updates, and other minor things #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/worker/test_workflow.py
# Conflicts: # .github/workflows/ci.yml # README.md # temporalio/worker/workflow.py # temporalio/workflow.py # tests/worker/test_workflow.py
# Conflicts: # temporalio/bridge/worker.py # temporalio/converter.py # temporalio/worker/workflow_instance.py # tests/test_converter.py
bergundy
reviewed
Jun 10, 2022
| @@ -624,6 +627,10 @@ For example, | |||
| [create a virtual environment](https://packaging.python.org/en/latest/tutorials/installing-packages/#creating-virtual-environments) | |||
| somewhere and then run the following inside the virtual environment: | |||
|
|
|||
| ```bash | |||
| pip install wheel | |||
There was a problem hiding this comment.
Should this just be a dev dependency?
There was a problem hiding this comment.
Yeah, I suppose so. It's only really needed on macOS to handle grpcio for some reason. Will add.
There was a problem hiding this comment.
Actually, this is already installed as a dev dependency (transitively), but the problem is the grpcio wheel needs it dynamically during install on macOS. This will hopefully go away when grpcio properly publishes a mac arm wheel.
bergundy
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Several small things:
grpciosource package for macOS armNo real logic changed
Why?
Preparing for release
(note, disregard the commit count, I based this off of #43 before it was merged)