Fix proto and add SA validation

README.md

@@ -57,6 +57,8 @@ These steps can be followed to use with a virtual environment and `pip`:
 
 The SDK is now ready for use. To build from source, see "Building" near the end of this documentation.
 
+**NOTE: This README is for the current branch and not necessarily what's released on `PyPI`.**
+
 ### Implementing a Workflow
 
 Create the following script at `run_worker.py`:

scripts/gen_protos.py

@@ -78,7 +78,9 @@ def fix_generated_output(base_path: Path):
                 # MyPy protobuf does not document this experimental class, see
                 # https://github.com/nipunn1313/mypy-protobuf/issues/212#issuecomment-885300106
                 import_suffix = ""
-                if stem == "service_pb2_grpc" and message == "WorkflowService":
+                if stem == "service_pb2_grpc" and (
+                    message == "WorkflowService" or message == "OperatorService"
+                ):
                     import_suffix = " # type: ignore"
                 f.write(f"from .{stem} import {message}{import_suffix}\n")
                 message_names.append(message)

temporalio/api/operatorservice/v1/__init__.py

@@ -8,8 +8,8 @@
     RemoveSearchAttributesRequest,
     RemoveSearchAttributesResponse,
 )
+from .service_pb2_grpc import OperatorService  # type: ignore
 from .service_pb2_grpc import (
-    OperatorService,
     OperatorServiceServicer,
     OperatorServiceStub,
     add_OperatorServiceServicer_to_server,

temporalio/converter.py

@@ -629,6 +629,10 @@ def encode_search_attribute_values(
                     "Timezone must be present on all search attribute dates"
                 )
             v = v.isoformat()
+        elif not isinstance(v, (str, int, float, bool)):
+            raise TypeError(
+                f"Search attribute value of type {type(v).__name__} not one of str, int, float, bool, or datetime"
+            )
         safe_vals.append(v)
     return default().payload_converter.to_payloads([safe_vals])[0]
 

tests/test_converter.py

@@ -1,4 +1,5 @@
 from dataclasses import dataclass
+from datetime import datetime
 
 import pytest
 
@@ -99,3 +100,10 @@ def test_binary_proto():
     assert payload.data == proto.SerializeToString()
     decoded = conv.from_payload(payload)
     assert decoded == proto
+
+
+def test_encode_search_attribute_values():
+    with pytest.raises(TypeError, match="of type tuple not one of"):
+        temporalio.converter.encode_search_attribute_values([("bad type",)])
+    with pytest.raises(ValueError, match="Timezone must be present"):
+        temporalio.converter.encode_search_attribute_values([datetime.utcnow()])