Preserve a previous exception in GrpcRetryer in case of DEADLINE_EXCEEDED #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
mfateev,
Sushisource and
vitarb
as code owners
Sushisource
reviewed
Aug 26, 2021
Comment on lines
33
to
35
| * not. | ||
| * |
There was a problem hiding this comment.
Probably worth mentioning here that in the face of DEADLINE_EXCEEDED errors, we will attempt to return original error
Sushisource
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #666
What was changed
Now GrpcRetryer preserves a previous exception and throws it in the case of DEADLINE_EXCEEDED if DEADLINE_EXCEEDED is not the first exception in the chain.
Why?
DEADLINE_EXCEEDED should be treated basically the same way as a retry timeout. The user of GrpcRetryer is interested in what happened and was retried and what eventually lead us to the timeout, not in the timeout or DEADLINE_EXCEEDED itself.
Closes #666
How was this tested:
GrpcRetyer unit tests