Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style improvements around DataConverters and WorkflowContext #627

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Code style improvements around DataConverters and WorkflowContext #627

merged 1 commit into from
Aug 13, 2021

Conversation

vkoby
Copy link
Contributor

@vkoby vkoby commented Aug 12, 2021 •
edited
Loading

  • Clarification of javadocs around DataConverters and WorkflowContext classes
  • Code style fixes
  • Spelling/grammar errors
  • Google formatting

Spikhalskiy
Spikhalskiy suggested changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@Spikhalskiy Spikhalskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use descriptive commit messages and PR names, so people who watch the changes in this repo have an easier time understanding the changes.
"Cleanup" means nothing to somebody who browses through the changesets. Is it a cleanup to avoid a memory leak? Or cleanup of deprecated methods? Or a dead code? Or have we stopped putting some code-generated files into the repo?
A good message here could be "Code style fixes and clarification of javadocs around DataConverters and WorkflowContext classes"

@vkoby vkoby changed the title Cleanup Code style improvements around DataConverters and WorkflowContext Aug 13, 2021
@vkoby vkoby requested a review from Spikhalskiy August 13, 2021 03:42
@vkoby vkoby merged commit 58f02fe into temporalio:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spikhalskiy Spikhalskiy Spikhalskiy approved these changes

@mfateev mfateev Awaiting requested review from mfateev

@Sushisource Sushisource Awaiting requested review from Sushisource

@vitarb vitarb Awaiting requested review from vitarb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkoby @Spikhalskiy