Rework how DeterministicRunnerImpl and SyncWorkflowContext handle creation of workflow root and method threads #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
mfateev,
Sushisource and
vitarb
as code owners
Spikhalskiy
changed the title
Spikhalskiy
force-pushed
the
workflow-root-thread-refactoring
branch
5 times, most recently
from
c90eaf6 to
e2d42f2
Compare
mfateev
reviewed
Jun 30, 2021
temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowInboundCallsInterceptor.java
Outdated
Show resolved
Hide resolved
...oral-sdk/src/main/java/io/temporal/common/interceptors/WorkflowOutboundCallsInterceptor.java
Outdated
Show resolved
Hide resolved
| threads.add(c); | ||
| } | ||
| threadsToAdd.clear(); | ||
| workflowThreadsToAdd.clear(); |
There was a problem hiding this comment.
Should we do the same for the callback threads to add?
There was a problem hiding this comment.
It's actually what I did in this PR, I made a collection callbackThreadsToAdd that works almost the same way (just traversed in a reversed order when we add to threads)
temporal-sdk/src/main/java/io/temporal/internal/sync/SyncWorkflowContext.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/SyncWorkflowContext.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/common/interceptors/WorkflowInboundCallsInterceptor.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowThreadImpl.java
Outdated
Show resolved
Hide resolved
Spikhalskiy
force-pushed
the
workflow-root-thread-refactoring
branch
2 times, most recently
from
28dc52a to
c4be0e0
Compare
vitarb
reviewed
Jul 7, 2021
...ral-sdk/src/main/java/io/temporal/internal/sync/BaseRootWorkflowInboundCallsInterceptor.java
Outdated
Show resolved
Hide resolved
vitarb
reviewed
Jul 7, 2021
...ral-sdk/src/main/java/io/temporal/internal/sync/BaseRootWorkflowInboundCallsInterceptor.java
Outdated
Show resolved
Hide resolved
vitarb
reviewed
Jul 7, 2021
temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowThreadImpl.java
Show resolved
Hide resolved
Spikhalskiy
force-pushed
the
workflow-root-thread-refactoring
branch
4 times, most recently
from
49a4200 to
344b797
Compare
mfateev
approved these changes
Aug 11, 2021
Spikhalskiy
force-pushed
the
workflow-root-thread-refactoring
branch
from
344b797 to
3192980
Compare
…reation of workflow root and method threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored workflow root thread into a separate code path making it explicitly different from workflow-method thread and child workflows.
Added WorkflowInboundCallsInterceptor#newWorkflowMethodThread intercepting creation of the main workflow-method thread.
Added WorkflowInboundCallsInterceptor#newCallbackThread intercepting creation of a callback thread.
WorkflowOutboundCallsInterceptor#newThread is renamed into WorkflowOutboundCallsInterceptor#newChildThread and now it intercepts only new workflow child threads and doesn't intercept creation of the main workflow-method thread.
Fixed situation that the same "workflow-method" name was used for workflow initializer thread (now called "workflow-root") and for the thread that is used to run a workflow method (continued to be "workflow-method").
This PR is a first step to address issue #537