Add support for Kotlin in Async #319
Conversation
Spikhalskiy
requested review from
mfateev,
Sushisource and
vitarb
as code owners
|
|
|
Awesome! Thanks for driving this! |
|
Are you planning to convert this PR to "Ready to review status"? |
|
@mfateev Yes. My current priority is opentracing though. After preparing opentracing PR, I will polish this PR one more time and will open it for review. |
Spikhalskiy
force-pushed
the
async-kotlin
branch
2 times, most recently
from
f98b904 to
bf6ca46
Compare
Spikhalskiy
force-pushed
the
async-kotlin
branch
from
bf6ca46 to
c0e6914
Compare
| * Functions.Func} implementation | ||
| * @return promise on the return value of the asynchronous invocation of {@code func} | ||
| */ | ||
| private static <R> Promise<R> execute(boolean temporalStub, Functions.Func<R> func) { |
There was a problem hiding this comment.
Can temporalStub not be determined by inspecting func ?
There was a problem hiding this comment.
It can! but the point of this function is that we expected the func already earlier and provide this as an input. It's a private function, not a part of the class API.
| if (methodReferenceDisassemblyService == null) { | ||
| throw new IllegalStateException( | ||
| "Kotlin method reference is used with async. " | ||
| + "For Temporal to correctly support async invocation kotlin method references add temporal-kotlin to classpath"); |
There was a problem hiding this comment.
| + "For Temporal to correctly support async invocation kotlin method references add temporal-kotlin to classpath"); | |
| + "For Temporal to correctly support async invocation kotlin method references, add temporal-kotlin to classpath"); |
Spikhalskiy
force-pushed
the
async-kotlin
branch
14 times, most recently
from
791974a to
22d83c1
Compare
Spikhalskiy
force-pushed
the
async-kotlin
branch
5 times, most recently
from
cc8f368 to
369c809
Compare
Spikhalskiy
force-pushed
the
async-kotlin
branch
from
369c809 to
e370202
Compare
Previous behavior
Previously Async didn't handle method references on Temporal stubs coming from Kotlin correctly.
As the result, method references on Temporal stubs were treated as regular functions and executed as a new child thread of the workflow instead of just inline calls to an async stub.
There is a relevant post about this issue in an unrelated discussion: #537 (comment)
#Change
temporal-kotlin module has been added that provides support for correct temporal stubs detection inside Async if the method referenced is passed from kotlin code.
After merging this PR Kotlin users will have to add
io.temporal:temporal-kotlinmodule to the classpath or they will get an exception trying to use Async.