Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure workflow_task_execution_failed always has a failure_reason #2419

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

closes #2418

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner February 18, 2025 04:52
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bit confusing to follow with handle, but since it's just adding a tag to existing metric, LGTM. I am now curious the situation this code is called in because I am afraid it actually won't return a task failure to the server.

@Quinn-With-Two-Ns
Copy link
Contributor Author

I am now curious the situation this code is called in because I am afraid it actually won't return a task failure to the server.

Yes that is correct, we don't report a task to the server if we are retrying a task multiple times to control the task retry behaviour

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit a2455af into temporalio:master Feb 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflow_task_execution_failed metric sometime doesn't have failure_reason tag
2 participants