Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject namespace header #2400

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Inject namespace header #2400

merged 3 commits into from
Feb 4, 2025

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Inject Namespace in grpc headers. Unfortunately I couldn't use gRPC interceptors as originally proposed because java's gRPC interceptors cannot modify the header based of the content of the message grpc/grpc-java#4684 (comment)

closes #2058

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner February 3, 2025 22:54
cretz
cretz approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a separate issue, we should consider a test with cloud data plane and API key to confirm this works there, but I may open some separate issues on that.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit fd65ea9 into temporalio:master Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set Temporal-Namespace header on every namespace-specific gRPC request
2 participants
@Quinn-With-Two-Ns @cretz