Make sure GetVersion never yields #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Jan 17, 2025
Comment on lines
285
to
+287
| * @return True if the identifier is not present in history | ||
| */ | ||
| boolean getVersion( | ||
| Integer getVersion( |
Comment on lines
380
to
+382
| * @return True if the identifier is not present in history | ||
| */ | ||
| public boolean getVersion( | ||
| public Integer getVersion( |
There was a problem hiding this comment.
Docstring needs update here too
| @@ -75,6 +75,9 @@ public void testGetVersionOutOfOrderFail() { | |||
| assertEquals( | |||
| NonDeterministicException.class.getName(), | |||
| ((ApplicationFailure) e.getCause().getCause().getCause()).getType()); | |||
| assertEquals( | |||
| "[TMPRL1100] getVersion call before the existing version marker event. The most probable cause is retroactive addition of a getVersion call with an existing 'changeId'", | |||
There was a problem hiding this comment.
Suggested change
| "[TMPRL1100] getVersion call before the existing version marker event. The most probable cause is retroactive addition of a getVersion call with an existing 'changeId'", | |
| "[TMPRL1100] getVersion called before the existing version marker event. The most probable cause is retroactive addition of a getVersion call with an existing 'changeId'", |
cretz
approved these changes
Jan 21, 2025
@Sushisource not sure what you mean by "the whole two-phase thing"? |
Doing the change in two parts so rolling back one version would work. But, maybe I'm actually getting this mixed up with a different change. Doesn't matter either way. |
Quinn-With-Two-Ns
force-pushed
the
issue-2307
branch
from
70c1bbe to
fef88d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure GetVersion never yields