Avoid lock up on unexpected ExecutorService errors while executing Local Activities #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
la-executor-errors
branch
from
a1a5e73 to
c1a2a0d
Compare
Sushisource
force-pushed
the
la-executor-errors
branch
from
c1a2a0d to
2a8c377
Compare
| 10, | ||
| TimeUnit.SECONDS, | ||
| synchronousQueue ? new SynchronousQueue<>() : new LinkedBlockingQueue<>()); | ||
| new ThreadPoolExecutor(0, threadPoolMax, 10, TimeUnit.SECONDS, new SynchronousQueue<>()); |
There was a problem hiding this comment.
So I am fine with this change, but it will mean that any submission to the threadPoolTaskExecutor will not be blocking if the threadPoolMax is full. Did you confirm the submitter can handle this and we have appropriate test coverage?
There was a problem hiding this comment.
Made sure this works via a small change to testParallelLocalActivities
temporal-sdk/src/main/java/io/temporal/internal/worker/LocalActivitySlotSupplierQueue.java
Outdated
Show resolved
Hide resolved
Sushisource
force-pushed
the
la-executor-errors
branch
from
aba6d89 to
1c4ef46
Compare
Quinn-With-Two-Ns
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Avoid putting the worker into a useless state if submitting a local activity for execution fails (ex: OOM / other thread starting problems).
Why?
Bad times when you don't know why your worker is stuck
Checklist
Closes Failure to allocate thread can lock up local activities #2349
How was this tested:
Added an integration test with an executor service that fails intentionally
Any docs updates needed?