Add method to get workflow client from an activity #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jan 15, 2025
| * Get a {@link WorkflowClient} that can be used to start interact with the Temporal service from | ||
| * an activity. | ||
| */ | ||
| WorkflowClient getWorkflowClient(); |
There was a problem hiding this comment.
I assume we don't expect users to have their own implementations of ActivityExecutionContext? I know we have a TestActivityEnvironment, just wanted to check. If you do make another commit in this PR, may be worth a warning at the top of this interface saying that methods may be added without default implementations and that users should not implement this interface. Otherwise we should consider a default implementation that throws.
There was a problem hiding this comment.
We have ActivityExecutionContextBase if users want to provide their own wrapper implementation but not have to implement every method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method to get workflow client from an activity.
closes #2362