Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nexus error rehydration #2365

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Nexus error rehydration #2365

wants to merge 13 commits into from

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Nexus error rehydration

bergundy
bergundy approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly reviewed the conversion logic and test cases.

temporal-sdk/src/main/java/io/temporal/internal/nexus/NexusTaskHandlerImpl.java
Comment on lines +201 to +203
// FIX BEFORE MERGED - Right now the Go SDK is returning operation errors for cancel
// operations
// convertKnownFailures(failure);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on finalizing the behavior so we can merge this ASAP.

temporal-test-server/src/main/java/io/temporal/internal/testservice/StateMachines.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @bergundy