Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor workflow init validation #2316

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Refactor workflow init validation #2316

merged 4 commits into from
Nov 14, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Refactor workflow init validation so if a @WorkflowInit annotation is detected we always make sure it is correct.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner November 13, 2024 18:02
cretz
cretz approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming this does not affect any users not using @WorkflowInit

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 7ab0f6c into temporalio:master Nov 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz