Rename UpdateHandle to WorkflowUpdateHandle (💥 - incompatible change) #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
UpdateHandle
branch
2 times, most recently
from
c4aefc5 to
bf2a136
Compare
stephanos
force-pushed
the
UpdateHandle
branch
from
bf2a136 to
ed42d7c
Compare
cretz
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
LGTM. I'm adding a 💥 to the PR description since it's backwards incompatible and we will need to clarify in next release notes. May want to wait for @Quinn-With-Two-Ns approval.
cretz
changed the title
|
LGTM, you'll need to create a |
|
Let me know if you need any help with that! |
Quinn-With-Two-Ns
approved these changes
Sep 3, 2024
|
LGTM! |
dandavison
added a commit
to temporalio/documentation
that referenced
this pull request
Sep 4, 2024
fairlydurable
added a commit
to temporalio/documentation
that referenced
this pull request
Sep 12, 2024
* Initial pass to bring Java Messaging into compliance * Stopping for lunch * First pass for Java * Responding to Dan's comments * Final SDK team edits * More SDK team edits * s/UpdateHandle/WorkflowUpdateHandle/ temporalio/sdk-java#2204 * Clarify taxonomy of errors received by signal, update, and query * Fix link to #signals in Python docs * Delete link to sample * Revert to dynamic components content from main * Remove yellow highlight TODOs cc @fairlydurable * Update docs/develop/java/message-passing.mdx --------- Co-authored-by: Dan Davison <[email protected]>
fairlydurable
added a commit
to temporalio/documentation
that referenced
this pull request
Sep 16, 2024
* Java SDK message passing docs * Make sure docs link point to latest * Include language in exception * Add Troubleshooting section * Bring over new intro + a few minor edits * Move message-handling patterns section ahead of troubleshooting * Fix docusaurus build * EDU-670: Backport Java into Python Coverage (#3036) * Initial pass to bring Java Messaging into compliance * Stopping for lunch * First pass for Java * Responding to Dan's comments * Final SDK team edits * More SDK team edits * s/UpdateHandle/WorkflowUpdateHandle/ temporalio/sdk-java#2204 * Clarify taxonomy of errors received by signal, update, and query * Fix link to #signals in Python docs * Delete link to sample * Revert to dynamic components content from main * Remove yellow highlight TODOs cc @fairlydurable * Update docs/develop/java/message-passing.mdx --------- Co-authored-by: Dan Davison <[email protected]> * Mention timeout feature of wait_condition * Convert "async" language to "blocking" * Fix typo * Update docs/develop/java/message-passing.mdx Co-authored-by: Erica Sadun <[email protected]> * Apply suggestions from code review Co-authored-by: Erica Sadun <[email protected]> * Apply suggestions from code review Co-authored-by: Erica Sadun <[email protected]> * Fix links --------- Co-authored-by: Dan Davison <[email protected]> Co-authored-by: Erica Sadun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Renamed
UpdateHandletoWorkflowUpdateHandle.This is a breaking change.
Why?
Consistency. (as discussed previously)
Checklist
How was this tested:
Existing tests.
Any docs updates needed?
I checked https://docs.temporal.io/develop/java/message-passing and the
UpdateHandletype isn't mentioned anywhere.I also cannot see it in the samples repo (search)
The release docs will need to mention this change, though.