Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding attempt number into MDC context for better diagnosing #2193

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

javiercanillas
Copy link
Contributor

What was changed

Added a new LoggerTag for the Attempt number for LocalActivityWorker, ActivityWorker and WorkflowWorker.

Why?

When diagnosing logs it's quite useful to have this value, specially when executions may overlap each other.

Checklist

  1. Closes Missing Attempt value on MDC for logging purposes #2192

  2. How was this tested:
    Run tests locally, change is quite simple, I didn't do further testing.

  3. Any docs updates needed?
    I didn't find it required. Am I missing something?

Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to add to workflow task too

@Quinn-With-Two-Ns
Copy link
Contributor

Feature tests are failing because your branch does not include git tags. Please push them to your branch and let me know so I can re run CI.

@javiercanillas
Copy link
Contributor Author

@Quinn-With-Two-Ns done, created a none tag for this matter.

@Quinn-With-Two-Ns
Copy link
Contributor

@javiercanillas You need to ensure your branch has the tags of master. You can specify --tags when you fetch

@javiercanillas
Copy link
Contributor Author

javiercanillas commented Aug 20, 2024

@Quinn-With-Two-Ns ok. I was missing local configuration for the upstream repository. Just pushed all the tags on the origin. It might be hopefully resolved.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit f2e113a into temporalio:master Aug 21, 2024
8 checks passed
stephanos added a commit to stephanos/sdk-java that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Attempt value on MDC for logging purposes
3 participants